Saulparedes/fix ingress test #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saul Paredes <[email protected]>
Signed-off-by: Saul Paredes <[email protected]>
Redent0r
added
the
upstream/not-needed
Redent0r
commented
Feb 19, 2024
| spec: | ||
| containers: | ||
| - name: ubuntu-main | ||
| image: "docker.io/library/ubuntu:latest" | ||
| image: "docker.io/library/ubuntu:jammy-20240212" |
Author
There was a problem hiding this comment.
Start using fixed tags instead of latest on common images that sometimes fail in our internal e2e tests due to "outdated yaml".
-
Pro: increase test stability, should reduce/eliminate test failures due to "outdated yaml"
-
Con: We are no longer testing
latestand now we should move this fixed tags forward from time to time
I'm leaning on this change because we get a sporadic test failure every week roughly, but there's only been one instance that it has mildly helped us to test the latest version of an image.
manuelh-dev
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream-missinglabel (orupstream-not-needed) has been set on the PR.Summary
latestto a fixed tag, to reduce the occurance of sporadic internal e2e failures due to outdated yamls)Test Methodology
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=509203&view=results [Pass]